[Digikam-devel] Re: [digikam] digikam/items: Implement operation on all selected images for the rating on rotation overlay.

Gilles Caulier caulier.gilles at gmail.com
Fri Mar 11 08:36:56 GMT 2011


2011/3/7 Marcel Wiesweg <marcel.wiesweg at gmx.de>:
> Git commit 1bd6884ff54022e6ba5bac55dbb25f678ed1074e by Marcel Wiesweg.
> Committed on 07/03/2011 at 16:21.
> Pushed by mwiesweg into branch 'master'.
>
> Implement operation on all selected images for the rating on rotation overlay.
> On the way, clean up code duplication mostly in the rotate overlays.
>
> Question: Now, one click can be very powerful and edit a large number of images.
> Should we add a confirmation KMessageBox if the number of edited images exceeds
> a constant (n = 5, 10?)?
>
> CCMAIL: digikam-devel at kde.org
>
> M  +13   -34   digikam/items/digikamimageview.cpp
> M  +3    -3    digikam/items/digikamimageview.h
> M  +34   -8    digikam/items/digikamimageview_p.cpp
> M  +3    -2    digikam/items/digikamimageview_p.h
> M  +11   -1    digikam/items/imageratingoverlay.cpp
> M  +3    -1    digikam/items/imageratingoverlay.h
> M  +39   -89   digikam/items/imagerotationoverlay.cpp
> M  +22   -41   digikam/items/imagerotationoverlay.h
> M  +4    -4    digikam/items/imagethumbnailbar.cpp
> M  +1    -1    digikam/items/imagethumbnailbar.h
>
> http://commits.kde.org/digikam/1bd6884ff54022e6ba5bac55dbb25f678ed1074e

Give feedback to user is always a good idea. You can provide a message
box to bring user. Turn on the option to be able to do open this box
in the future.

Note : Icon view drawing is broken now. Look my message in devel ML...

Gilles Caulier



More information about the Digikam-devel mailing list