[Digikam-devel] Review Request: speedup fingerprints scan or recreation

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102104/
-----------------------------------------------------------

Review request for Digikam.


Summary
-------

Replace a QStringList by a QHash<QString,int>.
Callgrind confirm that what was 95% CPU in QStringList is now a 20% CPU only when recreating all the fingerprints,
less when scaning.


This addresses bug 273077.
    http://bugs.kde.org/show_bug.cgi?id=273077


Diffs
-----

  libs/threadimageio/loadingcache.h d664814 
  libs/threadimageio/loadingcache.cpp 87f80d9 

Diff: http://git.reviewboard.kde.org/r/102104/diff


Testing
-------

Run under callgrind recreating all the fingerprings (around 12000 images)
normally run, you can see there is no slowdown as the progress bar is filled.


Thanks,

Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20110727/afc2f819/attachment.html>