[Digikam-devel] [Bug 271030] Windows Live Photo Gallery people tagging Compatibility [patch]

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=271030





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-07-11 16:57:34 ---
Thanks a lot for digging through all this.
Some comments on your patch:

1) I would suggest to return a map name -> QRectF from DMetadata, so that all
string parsing of the specific storage format is done in the DMetadata class
and we get a rectangle in relative coordinates

2)There is elaborate code in FaceIFace to create a tag for a given name and
assign it, mostly FaceIface::FaceIfacePriv::tagForName and
FaceIface::FaceIfacePriv::add.
It seems now we need this in libdigikamdatabase. So we'd need another refactor
of this class (removing the Priv class, which holds no more data, just create
the FaceIface on the stack, give the class a better name) and splitting it,
because some methods call MetadataManager which is not in the libraries.

> I'd be inclined to make the "Reread Metadata from Image" always load
> the face data (and more).

Yes. This is scan mode Rescan (in ImageScanner) which mostly uses the same code
paths as NewScan, but at some places take care not to overwrite existing
information if there is no information from the metadata.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.