[Digikam-devel] [Bug 271030] Windows Live Photo Gallery people tagging Compatibility [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=271030


Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg at gmx.de




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2011-07-11 11:13:26 ---
You patch sound in the good way.

About your question:

+        // FIXME is there a function to build this string somewhere?
+        QString imageTagProperty("<rect x=\"%1\" y=\"%2\" width=\"%3\"
height=\"%4\"/>");

I'm not sure. I don't know if Marcel has factored this code somewhere. grep do
not give results here.

In your loop :

while(1) {
+        // FIXME QString::ascii() deprecated...use latin1 instead?
+        QString person = getXmpTagString(personPath.arg(i).ascii(), false);
+        QString rect   = getXmpTagString(rectPath.arg(i).ascii(), false);
+        if (person.isEmpty())
+            break;
+        i++;
+        faces[person] = rect;
+    }

XMP support UTF-8. We must use it to get person name. For rect, it sound fine.
Need to test of course. Do you have any test picture faced with M$ tags ?

Your patch implement face scanning at startup. It miss some mechanism to read
and write face tags on the fly when face are edited in digiKam. In order :

- implement DMetadata::setImageFacesPath()
- in digiKam, there are 2 classes named MetadataHub and MetadataManager used to
play info to read/store in image depending of user actions. Look in
digikam/digikam/metadata dir. You will see that face tags are not yet managed.

In Exiv2, some code need to be written too to handle XMP M$ face tags as well.
I can take a look.

Gilles Caulier

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.