[Digikam-devel] [Bug 264181] New: png-1.5 compatibility fix

[Thomas Klausner]

https://bugs.kde.org/show_bug.cgi?id=264181

           Summary: png-1.5 compatibility fix
           Product: digikam
           Version: 1.8.0
          Platform: NetBSD pkgsrc
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel at kde.org
        ReportedBy: tk at giga.or.at


Created an attachment (id=56384)
 --> (http://bugs.kde.org/attachment.cgi?id=56384)
Patch fixing the problem.

Version:           1.8.0 (using KDE 4.5.4) 
OS:                All

In png-1.5, the prototype for png_set_iCCCP changed. The fifth argument was a
png_charp and is now a png_bytep.

Reproducible: Always

Steps to Reproduce:
Compile digikam against png-1.5.

Actual Results:  
Here's the output from digikam-1.6.0, but the code is the same in SVN:

libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool
Digikam::PNGLoader::load(const QString&, Digikam::DImgLoaderObserver*)':
libs/dimg/loaders/pngloader.cpp:501: error: invalid conversion from 'char**' to
'png_byte**'
libs/dimg/loaders/pngloader.cpp:501: error:   initializing argument 5 of
'png_uint_32 png_get_iCCP(const png_struct*, const png_info*, char**, int*,
png_byte**, png_uint_32*)'
libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool
Digikam::PNGLoader::save(const QString&, Digikam::DImgLoaderObserver*)':
libs/dimg/loaders/pngloader.cpp:733: error: invalid conversion from 'char*' to
'const png_byte*'
libs/dimg/loaders/pngloader.cpp:733: error:   initializing argument 5 of 'void
png_set_iCCP(png_struct*, png_info*, const char*, int, const png_byte*,
png_uint_32)'


Expected Results:  
Successful compilation :)

I've attached a patch that fixes the problem with 1.5.0.
It probably needs changes to still work against older versions (which I don't
have installed).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.