[Digikam-devel] Unit Tests

[Andi Clemens]

Ok!

:-)

Andi

On Thu, 29 Dec 2011 20:48:24 +0100, Michael G. Hansen <mike at mghansen.de>  
wrote:

> On 12/29/2011 03:36 PM, Michael G. Hansen wrote:
>> Hi Andi,
>>
>> On 12/29/2011 01:37 PM, Andi Clemens wrote:
>>> I ran the unittest suite and 7 tests failed.
>>> I took a look at some of them and came across the test
>>> "test_kmlexport_gpxparsing", which I don't understand.
>>> The test "testQDateTimeParsing" doesn't make sense to me, we test Qt
>>> functions (why?) and always fail when comparing a time with
>>> QCOMPARE(time1.time(), QTime(0, 0, 0));
>>> which is always false.
>>
>> yes, we do test Qt functions here because the behavior of one of the
>> parsing functions changed with a version change in Qt. There was a
>> change in how they interpret the timezone offset. I will adapt them to
>> what the current version of Qt does.
>
> Done!
>
> Michael
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/