[Digikam-devel] [Bug 290022] New: Edit and Rotate in the Light Table open or change the wrong image

[Andrew Coles]

https://bugs.kde.org/show_bug.cgi?id=290022

           Summary: Edit and Rotate in the Light Table open or change the
                    wrong image
           Product: digikam
           Version: 2.4.1
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Light Table
        AssignedTo: digikam-devel at kde.org
        ReportedBy: andrew.i.coles at googlemail.com


Version:           2.4.1 (using KDE 4.7.3) 
OS:                Linux

If an image is on the light-table and right-clicked on, then choosing Edit or
Rotate does not edit/rotate the image that was right-clicked on - instead, it
edits/rotates the image that is currently selected in the icon view in the main
digiKam window.

If nothing is selected in the main window, then the edit and rotate options
disappear in the light table.  Everything else seems fine, e.g. 'Open With' or
'Move to Trash' use the correct image.

(As far as I can tell, the problem is that the context menu is using globally
defined actions, rather than being tailored to the image that has been
right-clicked on.  For instance, clicking Edit triggers the global "image_edit"
action.  This is connected to DigikamView::slotImageEdit(), which calls
'd->iconView->openCurrentInEditor();'.  I don't know the internals of digiKam
well enough to be able to know the best way to fix it, hence no patch, sorry
guys.)

Reproducible: Always

Steps to Reproduce:
Steps to reproduce - for edit:

1) Pick four images, add to light table
2) Drag one of the images into the left or right pane on the light table
3) Pick something else in the main window
4) Right-click the image on the light table, pick edit
5) The image editor will open the image chosen in step (3)

Or, for rotate:

1) Pick four images, add to light table
2) Drag one of the images into the left or right pane on the light table
3) Pick something else in the main window
4) Right-click the image on the light table, rotate it right by 90 degrees
5) The image selected at (3) will be rotated instead

Actual Results:  
The image selected at step (3) is edited/rotated.

Expected Results:  
The image that was right-clicked on is edited/rotated.

It happens on older versions of digiKam too - I've noticed it for a while but
have never worked out exactly what it is, other than sometimes the wrong image
appears in the editor.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.