[Digikam-devel] [Bug 289779] New: Plugins are not really freed / unplugged when disabled in the kipi setup dialog
Andi Clemens
andi.clemens at googlemail.com
Sun Dec 25 13:53:55 GMT 2011
https://bugs.kde.org/show_bug.cgi?id=289779
Summary: Plugins are not really freed / unplugged when disabled
in the kipi setup dialog
Product: digikam
Version: 2.5.0
Platform: Compiled Sources
OS/Version: Linux
Status: NEW
Severity: crash
Priority: NOR
Component: Kipiinterface
AssignedTo: digikam-devel at kde.org
ReportedBy: andi.clemens at googlemail.com
Version: 2.5.0 (using KDE 4.7.3)
OS: Linux
When I unplug a kipiplugin in digiKam, it shows different issues:
1. The icon is not shown anymore (can be fixed by adding an icon to the desktop
files (currently doing this)
2. The setup dialog crashes for all plugins that have no icon defined in the
desktop file, e.g. the calendar plugin. If you disable it and reenter the setup
dialog, digiKam crashes.
This happens because the plugin is not really unloaded and holds references on
the plugin actions, but these actions have been deleted, so accessing the
action makes digiKam crash.
We have 3 signals in the PluginLoader, two of them are not used (plug / unplug)
and one deprecated signal, which is used (replug).
I will provide a fix for the crash and also for the missing icons, but maybe
someone else should take a look at the code after my patch has been applied,
because there was (at least) an attempt to use the signals plug / unplug, but
it never did happen.
We either remove those signals (and make "replug" non-deprecated) or another
solution must be found.
I know this crash is reported from time to time and we always thought it was
fixed, but it actually never was. So I reopen the issue by opening a new bug.
Reproducible: Didn't try
Steps to Reproduce:
See above
Actual Results:
crashes, plugins are not unloaded
Expected Results:
should not crash, plugins should be unloaded
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the Digikam-devel
mailing list