[Digikam-devel] [Bug 288461] New: digikam: bashism in /bin/sh script [patch]

[Mark Purcell]

https://bugs.kde.org/show_bug.cgi?id=288461

           Summary: digikam: bashism in /bin/sh script [patch]
           Product: digikam
           Version: 2.3.0
          Platform: Debian unstable
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel at kde.org
        ReportedBy: msp at debian.org


Version:           2.3.0 (using KDE 4.7.3) 
OS:                Linux

# http://bugs.debian.org/581078
#
Index: digikam-2.2.0/core/utilities/scripts/cleanup_digikamdb/cleanup_digikamdb
===================================================================
---
digikam-2.2.0.orig/core/utilities/scripts/cleanup_digikamdb/cleanup_digikamdb  
    2011-10-03 21:34:14.000000000 +1100
+++ digikam-2.2.0/core/utilities/scripts/cleanup_digikamdb/cleanup_digikamdb   
2011-10-23 10:55:39.000000000 +1100
@@ -110,14 +110,14 @@

 cleanupDB()
 {
-    cd "$1" 2&> /dev/null
+    cd "$1" > /dev/null 2>&1
     if [ $? = 0 ]; then
         local db_out="${output_str_database}:"
-        echo -e "${output_str_location}:\t$(pwd)"
+        echo "${output_str_location}:  $(pwd)"

         for db in $(eval "find . ${db_find_cmd} 2> /dev/null")
         do
-            echo -ne "${db_out}\t${db} ... "
+            echo -n "${db_out} ${db} ... "
             sqlite3 ${db} "VACUUM;"
             if [ $? = 0 ]
             then
@@ -126,9 +126,12 @@
                 echo "failed!"
             fi
         done
-        echo -e "\n=> Finished";
+        echo
+        echo "=> Finished"
     else
-        echo -e "\nI was not able to enter the database folder.\n"
+        echo
+        echo "I was not able to enter the database folder."
+        echo
         echo "Make sure that the variable '${config_key}' in your 'digikamrc'
config file"
         echo "is set correctly and that you have permissions to access the
database folder."
     fi


Reproducible: Always

Steps to Reproduce:
Source code inspection


Expected Results:  
https://wiki.ubuntu.com/DashAsBinSh

OS: Linux (x86_64) release 3.1.0-1-amd64
Compiler: gcc

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.