[Digikam-devel] Remove DPopupMenu?

[Andi Clemens]

Ok... I'll commit soon.

Andi

On Sun, 14 Aug 2011 09:23:10 +0200, Gilles Caulier  
<caulier.gilles at gmail.com> wrote:

> Let's go to remove it...
>
> Gilles
>
> 2011/8/14 Andi Clemens <andi.clemens at googlemail.com>:
>> If we fix it, we need to use the DPopupMenu everywhere, otherwise it  
>> isn't a
>> consistent layout.
>> I'd prefer to remove it, but as Marcel already said, I am not the one  
>> who
>> initially added the code :-)
>> I have a local branch with the DPopupMenu removed, I only need to merge  
>> it
>> with master.
>>
>> Gilles,
>> I guess you have to decide.
>>
>> Andi
>>
>>
>> On Sat, 13 Aug 2011 19:19:20 +0200, Gilles Caulier
>> <caulier.gilles at gmail.com> wrote:
>>
>>> Andi,
>>>
>>> DPopupMenu is broken due to my commit :
>>>
>>>
>>> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/03200ce1412f6425018e2b003a9b0c1d9a91d585
>>>
>>> This patch works fine with Qt 4.6.x, not Qt4.7.x
>>>
>>> The reason of this patch is to solve this entry :
>>>
>>> https://bugs.kde.org/show_bug.cgi?id=274388
>>>
>>> Christoph from Oxygen team explain the reason here :
>>>
>>> https://bugs.kde.org/show_bug.cgi?id=278365#c2
>>>
>>> If you feel to fix it, let's go. If it's too complicated, let's go to
>>> remove it...
>>>
>>> Best
>>>
>>> Gilles
>>>
>>> 2011/8/13 Marcel Wiesweg <marcel.wiesweg at gmx.de>:
>>>>
>>>>> DPopupMenu is currently broken, the sidebar image is not drawn and I  
>>>>> was
>>>>> thinking about removing the class completely.
>>>>> Why do we need to draw the digikam logo in there, when we plaster it  
>>>>> on
>>>>> every windows and dialog anyway?
>>>>> Also if we draw the sidebar image in the imagepreview and imageview
>>>>> context menu, we should do so for the albumselectview as well, to be
>>>>> consistent.
>>>>>
>>>>> I really don't see a purpose of the sidebar image, it renders a  
>>>>> little
>>>>> bit
>>>>> slower than a normal KMenu, and, at least for me, it is distracting.
>>>>> The user already knows that he is using digiKam, at least he started  
>>>>> the
>>>>> app so I guess he knows what he is doing :-)
>>>>>
>>>>> So what do you think, shouldn't we just remove the DPopupMenu class?
>>>>
>>>> I never needed it, so I would not object to remove it, but I'm neither
>>>> the one
>>>> who initially added the code
>>>> _______________________________________________
>>>> Digikam-devel mailing list
>>>> Digikam-devel at kde.org
>>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>>
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> Digikam-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>>
>> --
>> Using Opera's revolutionary email client: http://www.opera.com/mail/
>> _______________________________________________
>> Digikam-devel mailing list
>> Digikam-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/