[Digikam-devel] Review Request: Do not hardcode ellipsis on splash screen messages

[Frederik Schwarzer]

> On May 28, 2011, 3:47 p.m., Marcel Wiesweg wrote:
> > Makes sense. After 2.0 not to break translations?
> 
> Frederik Schwarzer wrote:
>     Sure, did not know about string freeze. Can you ping me here when string freeze is over?
> 
> Frederik Schwarzer wrote:
>     (ping) Can this go in now?
> 
> Gilles Caulier wrote:
>     yes, i review it now...
>
> 
> Gilles Caulier wrote:
>     Patch applied to git master

Thanks.
(If you add REVIEW: ###### to your commit message, requests are automatically closed and the revision is noted)

For the record: http://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=78a2ee56bdd59a25d0bc46739244b694cb8ca5b0


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101434/#review3565
-----------------------------------------------------------


On May 24, 2011, 6:35 p.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101434/
> -----------------------------------------------------------
> 
> (Updated May 24, 2011, 6:35 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Summary
> -------
> 
> The ellipsis is always added to the "right" of the string, which is not the "end" of the string in all languages.
> Also, in some languages (e.g. German) there has to be a space between the words and the ellipsis.
> 
> It seems more sane to let translators see that there is an ellipsis.
> 
> 
> Diffs
> -----
> 
>   digikam/main/digikamapp.cpp 429fa5c 
>   libs/widgets/common/splashscreen.cpp 78122ee 
> 
> Diff: http://git.reviewboard.kde.org/r/101434/diff
> 
> 
> Testing
> -------
> 
> None. Sorry, I cannot compile on my box. :(
> 
> 
> Thanks,
> 
> Frederik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20110809/7fa23f29/attachment.html>