[Digikam-devel] Re: [digikam] libs/dimg/filters/bw: currentOutputChannel is never used, so we don't need to check the channels at

[Johannes Wienke]

Andi updated to GCC 4.6 ;)

Am 23.04.2011 09:52 schrieb Andi Clemens:
> Git commit 9eca89cca025f85ee81a4a2207105945911285fa by Andi Clemens.
> Committed on 23/04/2011 at 09:22.
> Pushed by aclemens into branch 'master'.
> 
> currentOutputChannel is never used, so we don't need to check the channels at
> all. Saves us some execution time.
> 
> M  +15   -15   libs/dimg/filters/bw/mixersettings.cpp     
> 
> http://commits.kde.org/digikam/9eca89cca025f85ee81a4a2207105945911285fa
> 
> diff --git a/libs/dimg/filters/bw/mixersettings.cpp b/libs/dimg/filters/bw/mixersettings.cpp
> index 65e7c65..e519671 100644
> --- a/libs/dimg/filters/bw/mixersettings.cpp
> +++ b/libs/dimg/filters/bw/mixersettings.cpp
> @@ -493,7 +493,7 @@ void MixerSettings::loadSettings()
>  
>      if ( fp )
>      {
> -        ChannelType currentOutputChannel = RedChannel;
> +//        ChannelType currentOutputChannel = RedChannel;
>          char buf1[1024];
>          char buf2[1024];
>          char buf3[1024];
> @@ -504,20 +504,20 @@ void MixerSettings::loadSettings()
>  
>          fscanf (fp, "%*s %s", buf1);
>  
> -        // Get the current output channel in dialog.
> -
> -        if (strcmp (buf1, "RED") == 0)
> -        {
> -            currentOutputChannel = RedChannel;
> -        }
> -        else if (strcmp (buf1, "GREEN") == 0)
> -        {
> -            currentOutputChannel = GreenChannel;
> -        }
> -        else if (strcmp (buf1, "BLUE") == 0)
> -        {
> -            currentOutputChannel = BlueChannel;
> -        }
> +//        // Get the current output channel in dialog.
> +//
> +//        if (strcmp (buf1, "RED") == 0)
> +//        {
> +//            currentOutputChannel = RedChannel;
> +//        }
> +//        else if (strcmp (buf1, "GREEN") == 0)
> +//        {
> +//            currentOutputChannel = GreenChannel;
> +//        }
> +//        else if (strcmp (buf1, "BLUE") == 0)
> +//        {
> +//            currentOutputChannel = BlueChannel;
> +//        }
>  
>          fscanf (fp, "%*s %s", buf1); // preview flag, preserved for compatibility
>  


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20110423/8fd35e76/attachment.sig>