[Digikam-devel] [Bug 269862] New: libkmap compilation fails because of changes in MarbleWidget

[T.R.Shashwath]

https://bugs.kde.org/show_bug.cgi?id=269862

           Summary: libkmap compilation fails because of changes in
                    MarbleWidget
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: libkmap
        AssignedTo: digikam-devel at kde.org
        ReportedBy: trshash84 at gmail.com


Created an attachment (id=58489)
 --> (http://bugs.kde.org/attachment.cgi?id=58489)
Compilation fix for new marble version

Version:           unspecified (using Devel) 
OS:                Linux

Looks like the interface for MarbleWidget has changed again, and you shouldn't
use "marbleWidget->map()->fooBar()" anymore. Apparently, the calls are
forwarded to the backend map() object directly.

The compiler output is attached.

I worked around this problem by changing the relevant calls in
backend_map_marble.cpp (in three places). It compiles properly, but I haven't
run it to ensure that it works. The patch for this is also attached.

In the patch, I've added a new #if condition in backend_map_marble.cpp to
handle MARBLE_VERSION>=0x000c00, which is where this change happened,
apparently.

Reproducible: Always

Steps to Reproduce:
Update to a recent version of kdeedu from SVN
Attempt to build libkmap

Actual Results:  
makeobj[0]: Entering directory
`/mnt/new2/build/extragear/graphics/libkmap/libkmap'
[  0%] Built target kmap_automoc
[  5%] Building CXX object libkmap/CMakeFiles/kmap.dir/backend_map_marble.o
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
destructor ‘virtual KMap::BackendMarble::~BackendMarble()’:                     
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:178:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
member function ‘virtual QWidget* KMap::BackendMarble::mapWidget()’:
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:225:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp: In
member function ‘virtual QSize KMap::BackendMarble::mapSize() const’:
/mnt/new2/code/extragear/graphics/libkmap/libkmap/backend_map_marble.cpp:909:
error: ‘class Marble::MarbleWidget’ has no member named ‘map’
make[2]: *** [libkmap/CMakeFiles/kmap.dir/backend_map_marble.o] Error 1
make[1]: *** [libkmap/CMakeFiles/kmap.dir/all] Error 2
make: *** [all] Error 2
makeobj[0]: Leaving directory
`/mnt/new2/build/extragear/graphics/libkmap/libkmap'


Expected Results:  
It should compile properly.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.