[Digikam-devel] Re: [PATCH] [ERRATUM] Navigation and actions dock bar

[Luc Vieillescazes]

Hi,

Yes I agree with your first point, but in the same time I like the big 
thumbnails bar.... it's difficult to choose :-)
In the end, no problem to remove it.

For the second point, I can improve the patch and remove the widgets from the 
status bar, but I was waiting for developpers opinions.

If you are OK, I will submit a new version soon.

Thanks.
Luc

Le dimanche 26 septembre 2010 14:57:51 Andi Clemens, vous avez écrit :
> I've applied the patch and it works quite well, but there are some things I
> don't really like so far:
> 
> - The thumbbar spreads across the while digiKam window now, which shrinks
> the left and right sidebars vertically when switching from album to
> preview mode. This looks very hectic, the whole screen is moving around :D
> Another side-effect of this: The thumbbar will be attached on the left- and
> rightmost edges of the digikam window now. Before the patch the left and
> right sidebar were the left- and rightmost widgets.
> 
> - The status-bar still contains all the widgets that the new dockbar has,
> too. The patch should also fix this problem.
> 
> But in general, this patch seems to be ok.
> 
> Andi Clemens
> -----------------
> www.digikam.org
> 
> On Sunday 26 September 2010 14:31:12 Andi Clemens wrote:
> > No not yet, I will test it now.
> > 
> > Andi Clemens
> > -----------------
> > www.digikam.org
> > 
> > On Sunday 26 September 2010 14:20:05 Gilles Caulier wrote:
> > > First, i don't like review board tool. It break QA done with bugzilla.
> > > All workflow is broken as we cannot link bugzilla to review board.
> > > 
> > > There is no advantage to use review board instead bugzilla.
> > > 
> > > Sorry for this wrong feedback, but it's already difficult to manage
> > > the whole bugzilla entries. We don't need another tool again in the
> > > pending list.
> > > 
> > > Luc,
> > > 
> > > this is not against your work. Your patch is really appreciate, and
> > > it's now the time to review it indeep before inclusion to trunk
> > > 
> > > Andi,
> > > 
> > > do you have tested the last version of patch on your computer ?
> > > 
> > > Gilles
> > > 
> > > 2010/9/1 Luc Vieillescazes <luc at vieillescazes.net>:
> > > > 2010/8/31 Marcel Wiesweg <marcel.wiesweg at gmx.de>
> > > > 
> > > >> > Hi,
> > > >> > 
> > > >> > I made a new version some days ago
> > > >> > (http://reviewboard.kde.org/r/4905/). The changes are :
> > > >> > - Thumbnails bar now uses all the width in Preview mode (suggested
> > > >> > by Aditya Bhatt)
> > > >> 
> > > >> Does that mean the sidebar are shrunk vertically when going to
> > > >> preview mode?
> > > > 
> > > > Yes, you can see screenshots on http://reviewboard.kde.org/r/4905/,
> > > > one in album mode, one in preview mode
> > > > 
> > > >> > - The filter bar is only visible in Album mode,
> > > >> 
> > > >> There is some usefulness of the filters in any mode...
> > > > 
> > > > From my point of view, when normal users are looking for something,
> > > > they want to see all the results (so in album mode) and not only the
> > > > first like in preview mode.
> > > > 
> > > > But for "power" users, maybe we could add an "advanced button" (like
> > > > the search bar in Kate) to show/hide the filters ?
> > > > 
> > > >> > and navigation buttons only
> > > >> > in Preview mode.
> > > >> > - Correct a bug in digikam when switching form Preview mode to
> > > >> > Album mode,
> > > >> > the zoombar was not refresh.
> > > >> > - Rework a bit the layout / add tooltip
> > > >> > 
> > > >> > I hope you can give me some feedbacks :-)
> > > >> 
> > > >> _______________________________________________
> > > >> Digikam-devel mailing list
> > > >> Digikam-devel at kde.org
> > > >> https://mail.kde.org/mailman/listinfo/digikam-devel
> > > > 
> > > > _______________________________________________
> > > > Digikam-devel mailing list
> > > > Digikam-devel at kde.org
> > > > https://mail.kde.org/mailman/listinfo/digikam-devel
> > > 
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > Digikam-devel at kde.org
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
> > 
> > _______________________________________________
> > Digikam-devel mailing list
> > Digikam-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/digikam-devel
> 
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel