[Digikam-devel] [Bug 251920] Digikam should match lenses on Exif.CanonCs.LensType, not ExifCanonCs.Lens

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=251920





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-10-23 09:32:09 ---
Martin,

There is 2 way to fix this problem: the regex is done in liblensfun using
GLib2. I suspect that code is not perfect at this place. This can be fixed in
lensfun code of course and reported to lensfun project to backport patch. 

This is done by this stage 1 : 

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#275

Another way is to patch the digiKam lenfun interface to process a regex based
on Qt4::QString. Stage 2 is specific to Nikon camera/lens: 

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#280

There is the last stage :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#294

I recommend to add a new stage for Canon camera before last stage, if you
choose to patch digiKam lensfun interface source code.

Please patch trunk, i will backport later GSoC 2010 branch.

Gilles Caulier

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.