[Digikam-devel] Re: [Kde-graphics-devel] libkmap and libkface moved to kdereview

[Michael G. Hansen]

On 11/24/2010 08:20 PM, Albert Astals Cid wrote:
> libkmap seems to have a hard dependency on marble, in the past we didn't want
> those, nor sure if that rule is still there. But if it is not, can you turn
> that hard dependency into a soft one, please?

Initially, the plan was to not have a hard dependency on Marble, but 
then we ended up using many of the geo-related helper classes from 
Marble that would have otherwise to be rewritten.

> Seems like you are missing const in some getter functions like
> GeoCoordinates::Pair getSelectionRectangle();
>
> Also AbstractMarkerTiler is all inline and has no d-pointer, not sure if you
> plan maintaining binary compatibility on this lib or not.

I will look into those.

Regards,

Michael