[Digikam-devel] Re: extragear/graphics/digikam/libs/dimg/filters/fx

[Andi Clemens]

Ah ok so we are going to remove CImg? If so, we could remove the blur effect 
anyway, without using the compile flag now...?


Andi Clemens
-----------------
www.digikam.org

On Friday 12 November 2010 22:31:23 Gilles Caulier wrote:
> because, we don't control it.
> 
> CImg is a large libs. blur is a simple effect. It's more easy to
> maintain our code.
> 
> I imported CImg only for greystoration feature, which is a very
> complex algorithm. Since One year this code have been moved to another
> library named GMic. Why ? To provide a script framework.
> 
> http://gmic.sourceforge.net/
> 
> The problem is that all is broken now with CImg. This lib has
> progressed but is not compatible since 1.3.1.
> 
> CImg 1.3.0, imported in digiKam core is pretty old now. The solution
> is to use CMig now. I started this job, but it's complex and long
> job...
> 
> http://digikam3rdparty.free.fr/misc.tarballs/gmicport.patch.gz
> 
> Gilles
> 
> 2010/11/12 Andi Clemens <andi.clemens at gmx.net>:
> > I used CImg because it is nearly 20 times faster.
> > Why implement such algorithmns on our own if there are ready-to-use, well
> > known and tested libraries :-) ?
> > 
> > 
> > Andi Clemens
> > -----------------
> > www.digikam.org
> > 
> > On Friday 12 November 2010 18:53:57 Marcel Wiesweg wrote:
> >> > SVN commit 1196146 by cgilles:
> >> > 
> >> > Andy, this is not understadable.
> >> > All CImg::*blur() method crash under MacOsX. and i don't know why...
> >> > Probably, this is fixed with last CImg 1.4.x release, as digiKam still
> >> > use 1.3.0... but we cannot update because all Greystoration algorithm
> >> > have been removed from CImg and migrated to GMic library The solution
> >> > is to port greystoration code to GMic, as it have been recommended by
> >> > CImg author in the past by a private mail. But it's a long and
> >> > complex task. Note : Greystoration tools do not crash under MAC Os X
> >> > !!! I'm lost... So, I restore old gaussian blur algorithm for Mac
> >> > only...
> >> 
> >> What is the advantage of generally using the CImg variant instead of our
> >> own code? Do they produce different results?
> >> _______________________________________________
> >> Digikam-devel mailing list
> >> Digikam-devel at kde.org
> >> https://mail.kde.org/mailman/listinfo/digikam-devel
> > 
> > _______________________________________________
> > Digikam-devel mailing list
> > Digikam-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/digikam-devel
> 
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel