[Digikam-devel] [Bug 148540] Improvements of adding noise tool

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=148540


Gilles Caulier <caulier.gilles at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #51 from Gilles Caulier <caulier gilles gmail com>  2010-03-23 16:37:15 ---
Julien,

I think the chrominance noise generator is not too bad, excepted in shadows and
hightlight. 

Conversion in YCbCr color space is done in floating point to prevent rounding
error. Noise is added to Chroma red and blue chanels and clamped to prevent
saturation.

But, with highkey or lowkey photo, color are saturated if noise is too
important. I don't know why exactly, but i suspect a problem with the
"footroom" and the "headroom" values as explained in wikipidia page :

http://en.wikipedia.org/wiki/YCbCr

In this page these ranges are defined for 8 bits color depth integer conversion
matrix, not for floating point conversion matrix. So i have a doubt here, but i
think that clamping values must be adjusted accordingly [not clamp(0.0, 1.0,
chroma].

What do you think about ?

Gilles Caulier

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.