[Digikam-devel] branches/extragear/graphics/digikam/libkface

[Gilles Caulier]

2010/6/16 Johannes Wienke <jwienke at techfak.uni-bielefeld.de>:
> Hi,
>
> jsut as a question: since 2.0 opencv installs a pkgconfig file, too. Why
> don't you use this instead of a find macro?
>

Right. this must be fixed.

Gilles

> Regards,
> Johannes
>
> Aditya Jitesh Bhatt wrote:
>> SVN commit 1138615 by adityab:
>>
>> Moved OpenCV check to a better place.
>>
>>  M  +2 -0      CMakeLists.txt
>>  M  +0 -2      libkface/CMakeLists.txt
>>
>>
>> --- branches/extragear/graphics/digikam/libkface/CMakeLists.txt #1138614:1138615
>> @@ -1,6 +1,8 @@
>>  PROJECT(libkface)
>>
>>  FIND_PACKAGE(KDE4 REQUIRED)
>> +FIND_PACKAGE(OpenCV REQUIRED)
>> +
>>  INCLUDE(KDE4Defaults)
>>  INCLUDE(MacroLibrary)
>>  INCLUDE(MacroOptionalAddSubdirectory)
>> --- branches/extragear/graphics/digikam/libkface/libkface/CMakeLists.txt #1138614:1138615
>> @@ -5,8 +5,6 @@
>>  ADD_DEFINITIONS(${KDE4_ENABLE_EXCEPTIONS})
>>  REMOVE_DEFINITIONS(-DQT_NO_STL)
>>
>> -FIND_PACKAGE(OpenCV REQUIRED)
>> -
>>  CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/version.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/version.h)
>>
>>  # This was used to enable catching of exceptions thrown by libexiv2.
>
>
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>