[Digikam-devel] extragear/graphics/digikam/tests

[Andi Clemens]

SVN commit 1133923 by aclemens:

Avoid defining the content of libadvancedrename_SRCS twice.

But why do we do it like this anyway?
Why don't we use static libs for all the lib***_SRCS defines?
For example AdvancedRename is compiled three times, for the digiKam target, for
the tests target and for the themedesigner target.
This is true for a lot of other things, too.

Why don't we use static libs and just link them in the end?
Other candidates would be libdigikamgui, libsearchwindow etc...

Is there any reason why it is not done this way?

CCMAIL:digikam-devel at kde.org

 M  +1 -29     CMakeLists.txt  


--- trunk/extragear/graphics/digikam/tests/CMakeLists.txt #1133922:1133923
@@ -48,35 +48,7 @@
 
 SET(advancedrenametest_SRCS
     advancedrenametest.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/modifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/option.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/parseable.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/parseabledialog.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/tooltipdialog.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/parser.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/parseresults.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/common/token.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/defaultrenameparser.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/importrenameparser.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/casemodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/defaultvaluemodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/rangemodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/replacemodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/trimmedmodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/modifiers/uniquemodifier.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/cameranameoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/databaseoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/dbkeyselector.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/dbkeyscollection.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/dbheaderlistitem.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/keys/commonkeys.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/keys/metadatakeys.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/database/keys/positionkeys.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/dateoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/directorynameoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/filepropertiesoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/metadataoption.cpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/../utilities/advancedrename/parser/options/sequencenumberoption.cpp
+    ${libadvancedrename_SRCS}
 )
 KDE4_ADD_UNIT_TEST(advancedrenametest ${advancedrenametest_SRCS})
 TARGET_LINK_LIBRARIES(advancedrenametest