[Digikam-devel] [Bug 245380] improve the ergonomics of the bwsepia filter ui

[Manuel Viet]

https://bugs.kde.org/show_bug.cgi?id=245380





--- Comment #10 from Manuel Viet <contact 13zenrv fr>  2010-07-28 13:57:32 ---
(In reply to comment #9)

> Just a little remark : in preview icon view, when you start tool, it do not
> select the last used settings. In fact, tool apply it, but nothing is selected
> to icon view.

This most strange, and I'm completely lost here, because on my working copy the
behaviour is correct, and the preview icon is shown selected. (QT 4.5.3 & KDE
4.3.3 with updated kdegraphics.)

> For icons, i will review it later, after to have applied your patch on svn
> trunk (digiKam 1.4.0)

Thank you.

> Also, for digiKam 2.0.0, we use a separate branch, where i will fork from trunk
> libkdcraw, and integrate your expander patch directly.

That would be much more convenient. I tried to settle the geometry interactions
between my derived instance and the displayed objects from the outside, but I
realised I would need to worm a way through the QObject tree to get inside the
RExpanderBox main layout. Very bad (and bug-prone) practice, I scrapped my
attempts.

> For information, code is there. Warnings, it's unstable for the moment, do not
> use in production. It include all GSoC 2010 works, as Face detection, Image
> versioning, and reverse geolocation : 
> 
> http://websvn.kde.org/branches/extragear/graphics/

I'll sure peek a look as soon as I get back in mid-August.

> I hope that you will interested to patch more digiKam in the future. Your
> implementation is very suitable, very well written, and easily reviewable.

Well this is much undeserved praise, and I hope I can find new areas where
polishing efforts are needed :-)

Cheers, Manuel

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.