[Digikam-devel] [Bug 245336] Image editor does not remember camera profile under Custom

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=245336





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-07-23 14:54:38 ---
This is the code relevant :

RAW decoding setting widget instance :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#178

Read and Save settings call :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#442
http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#464

Which call these methods :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.cpp#933
http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.cpp#940

...and finally :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rawdecodingsettings.cpp#209
http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rawdecodingsettings.cpp#236

And the bug is there : where is the call to these last both method to read and
write input color space settings... Sound like i miss to write these lines...

Note : why 1.2.0 and 1.3.0 do not give the same result ? because i factorized a
lots API. You can see many methods which are now deprecated :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/dcrawsettingswidget.h#130

So the fix is very simple to do in rawdecodingsettings.cpp. Do you able to
manage a patch against svn trunk ? (:=)))

Gilles Caulier

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.