[Digikam-devel] code cleanup

Marcel Wiesweg marcel.wiesweg at gmx.de
Tue Feb 2 20:00:34 GMT 2010


> Hi all,
> 
> histogrambox and curvesbox use enum type 'HistogramScale' for get and set
> methods (defined in globals.h), but use int for get and set methods for
> channeltype as there is also a enum type 'ChannelType' also defined in
> globals.h. I want to make channeltype type-safe (use ChannelType enum) and
> have therefore to touch a dozen of files. Are there any objections against?

Fine for me.

> 
> Another thing: there a lot of '#if KDCRAW_VERSION < 0x000400' define
>  switches across the code, but according for README only libkdcraw >= 0.4.0
>  is supported. What about this?

0.4.0 was released with KDE SC 4.2. I think it's ok to remove support for 0.3 
and later.



More information about the Digikam-devel mailing list