[Digikam-devel] code cleanup

Jens Müller tschensinger at web.de
Tue Feb 2 19:29:08 GMT 2010


Hi all,

histogrambox and curvesbox use enum type 'HistogramScale' for get and set 
methods (defined in globals.h), but use int for get and set methods for 
channeltype as there is also a enum type 'ChannelType' also defined in 
globals.h. I want to make channeltype type-safe (use ChannelType enum) and 
have therefore to touch a dozen of files. Are there any objections against?

Another thing: there a lot of '#if KDCRAW_VERSION < 0x000400' define switches 
across the code, but according for README only libkdcraw >= 0.4.0 is 
supported. What about this?

Regards, Jens



More information about the Digikam-devel mailing list