[Digikam-devel] Re: extragear/graphics/digikam/utilities/advancedrename

[Johannes Wienke]

Hey,

just a short comment about using globbing for header and cpp files in cmake:
Some time ago I've read a lengthy discussion about this on the cmake
mailing list about this and the consensus was that this generally is not
a good idea, because it prevents the cmake cache from working correctly
here. If you add a file to a folder where globbing is use, cmake (at
least in the old versions) did not notice it, because the globbing
result was cached. So you had to remove the cache to compile this file.

Is this still the case?

Cheers,
Johannes

Am 17.12.2010 22:34 schrieb Andi Clemens:
> SVN commit 1207397 by aclemens:
> 
> simplify CMakeLists.txt
> 
>  M  +7 -6      CMakeLists.txt  
> 
> 
> --- trunk/extragear/graphics/digikam/utilities/advancedrename/CMakeLists.txt #1207396:1207397
> @@ -1,3 +1,4 @@
> +# sources
>  FILE(GLOB libadvancedrename_SRCS 
>          ${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
>          ${CMAKE_CURRENT_SOURCE_DIR}/common/*.cpp
> @@ -8,14 +9,14 @@
>          ${CMAKE_CURRENT_SOURCE_DIR}/parser/options/database/keys/*.cpp
>  )
>  
> -KDE4_ADD_UI_FILES(libadvancedrename_SRCS
> -        ${CMAKE_CURRENT_SOURCE_DIR}/parser/modifiers/fillmodifierdialogwidget.ui
> -        ${CMAKE_CURRENT_SOURCE_DIR}/parser/modifiers/replacemodifierdialogwidget.ui
> -        ${CMAKE_CURRENT_SOURCE_DIR}/parser/modifiers/rangemodifierdialogwidget.ui
> -        ${CMAKE_CURRENT_SOURCE_DIR}/parser/options/dateoptiondialogwidget.ui
> -        ${CMAKE_CURRENT_SOURCE_DIR}/parser/options/sequencenumberoptiondialogwidget.ui
> +# ui files
> +FILE(GLOB libadvancedrename_UI 
> +        ${CMAKE_CURRENT_SOURCE_DIR}/parser/modifiers/*.ui
> +        ${CMAKE_CURRENT_SOURCE_DIR}/parser/options/*.ui
>  )
>  
> +KDE4_ADD_UI_FILES(libadvancedrename_SRCS ${libadvancedrename_UI})
> +
>  KDE4_ADD_LIBRARY(advancedrename STATIC ${libadvancedrename_SRCS})
>  
>  TARGET_LINK_LIBRARIES(advancedrename


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20101217/ad13df5c/attachment.sig>