[Digikam-devel] [Bug 248087] Preview not toggling from video mode to image mode [patch]

[Berthier Lemieux]

https://bugs.kde.org/show_bug.cgi?id=248087





--- Comment #3 from Berthier Lemieux <berthier_lemieux hotmail com>  2010-08-17 22:03:38 ---
Created an attachment (id=50668)
 --> (http://bugs.kde.org/attachment.cgi?id=50668)
Proposed patch, improved version

Hi, here is a better fix for the issue, this time it handles the cases of
images not yet loaded. I feel good about that one.

In addition to the bug reported here, the patch fixes an other bug : the
rotation icons are not disabled when image preview is loading. That leads to a
situation where preview of image N is displayed, image N+1 preview is loading
but not yet ready, user press one of the rotate button, image N+1 is rotated. I
would expect that the image displayed (image N) would be rotated, not N+1. I
suppose this is really minor in reality, but became very apparent with my test
cases where I made the preview loading time to be *really* long.

I also removed the signal signalPreviewLoaded() that wasn't used by anyone.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.