[Digikam-devel] [PATCH] [ERRATUM] Navigation and actions dock bar

[Martin Klapetek]

Hi,

Although I agree that the original controls are kinda hidden down there, I
have a few remarks to your patch.

1) The controls are too big. They're taking too much real estate. Think
about users with small screens. They don't have much space and these
controls have plenty of wasted space around them. The status bar is just
better suited for this. Maybe you could try to improve that one? Or the
buttons there?

2) It copies most of the functionality already available elsewhere. For
example the preview - every control you have there is already there, except
of the delete button and the Back to album button (which is good idea btw).
Therefore you either need to get rid of the top toolbar completely and
replace it with your controls (the same goes with the status bar), or throw
out the duplicate controls. But then you would be left with just two or free
buttons, which would render it useless.

Anyway, you have nice coding style, very clean, elegant and digikam-ish :)

To lead devels/admins: Oh please go for reviewboard.kde.org - this tool is
really neat ;)

Marty


On Mon, Aug 2, 2010 at 23:14, Luc Vieillescazes <luc at vieillescazes.net>wrote:

> Sorry, the files navigationbar.cpp and navigationbar.h were not included in
> the
> patch.
> I attached them...
>
> Le lundi 02 août 2010 23:01:24 Luc Vieillescazes, vous avez écrit :
> > Hi,
> >
> > This is my first patch for Digikam. It adds a dock bar with navigation
> and
> > actions buttons in the bottom of the screen.
> >
> > More than thousand words, here are 2 screenshots :
> >
> > In Preview mode :
> > http://img291.imageshack.us/img291/4258/digikampreview.png
> >
> > In Album mode :
> > http://img293.imageshack.us/img293/5451/digikamalbum.png
> >
> > I made this patch to replace the status bar because I find the navigation
> > buttons are not enough visibles.
> > But for the moment my patch doesn't hide it.
> >
> > I hope you could give me feedbacks to tell me what's good and what's not
> > :-)
> >
> > Thanks.
> > Luc.
> >
> > PS : Have you ever thought about subscribe to reviewboard.kde.org ? I
> think
> > it's a good tool to exchange about a patch.
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20100803/810e2ce3/attachment.html>