[Digikam-devel] [Bug 229795] Position in album lost when switching album forth and back [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=229795





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2010-04-11 11:09:44 ---
Tested. The patch sound working fine.

Some remark about coding style :

always use m_ prefix for class members (sometime you use it, sometime no). A
lots of my time in digiKam project, i review code to polish implementation. The
goal is to have same coding style everywhere to have an homogenous
implementation. It's important.

about pointer declaration, use "MyClass*    ptr" is better than "MyClass    
*ptr" and align all of then, line by line.

When it's possible, use d private class container to speed up compilation, and
clean up include file in header implementation.

Marcel, check out again before patch inclusion in svn

Thanks

Gilles

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.