[Digikam-devel] [Bug 209207] Crash when deleting saved searches (GPS and Timeline)

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=209207


Marcel Wiesweg <marcel.wiesweg at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg at gmx.de




--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-10-04 15:53:34 ---
> When an album has been removed, set the search folder view to the current
> search again, otherwise we get crashes.
> A lot of album pointers in SearchFolderView still point to the currently
> deleted album, and since the album has been removed, we get a SegFault.
> 

There is also the option of using an AlbumPointer<> in these cases. See
albummanager.h at the bottom.

> Another problem:
> Create a search in GPS, call it 'aaa'.
> Create another search in Search, also call it 'aaa', you get a dialog that says
> that a search with this name already exists.
> Sure, behind the scenes all those searches are of one type, but for the normal
> 
> Marcel,
> any idea how to fix this?

Historically, we only had one type of searches, and this was all right. Now we
have plenty of types, and indeed there is no need for unique names. We can be
unique on type+name. This needs a change to all checkName() methods
copy-and-pasted in the sidebars, and a change to createSAlbum in the
AlbumManager.

(In reply to comment #12)
> I really don't understand these results, I checked all the variables and
> objects involved in it, but there is no null pointer or some other issue I can
> think of. But it always says:
> Invalid read of 4 at
> ==7256==  Address 0x39bafa90 is 0 bytes after a block of size 128 alloc'd  
> 
> so something has been deleted at this address, right?

Yes, seems to be.