[Digikam-devel] [Bug 209189] Make albumview rotation buttons optional

[Johannes Wienke]

https://bugs.kde.org/show_bug.cgi?id=209189


Johannes Wienke <languitar at semipol.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |digikam-devel at kde.org
         AssignedTo|digikam-devel at kde.org       |languitar at semipol.de
     Ever Confirmed|0                           |1




--- Comment #4 from Johannes Wienke <languitar semipol de>  2009-10-03 00:19:05 ---
(In reply to comment #3)
> > Do you mean only the rotation buttons or also the one for adding or removing an
> > image to or from a selection? 
> IMHO there is no need for a secondary selection method, there is a standard way
> of doing this in all KDE programs (hold the CTRL-key and then left click).. 

Gilles, what do you think? The overlay for the selection is added by the base
class ImageCategorizedView. I don't know if it's somewhere else used, so the
only non-intrusive way to remove that overlay in the view - that I see - is
adding a method to remove the overlay to ImageCategorizedView. But that sounds
like duplicate work... first adding it in the constructor and then removing it
afterwards. Maybe we should add a boolean parameter to the constructor to
auto-add this overlay defaulting to true for backwards-compatibility.
AlbumIconView can set this to false and use addSelectionOverlay based on the
settings.

> > Or do you think there should be two distinct options?
> I'm neither in favor of one or the other. As long as the vertical space can be
> recovered and the interface gets less hectic - I would always remove both...

Ok, then I'd suggest a single option to keep the GUI simple.

> >Regarding the space: There is not space reserved specially for these overlays.
> >If you got a squarish image, then all space of the album item is filled, except
> >a small decorative border.
> Well all my images are either 3:2 or 2:3. In the portrait orientation images
> the buttons overlap, in the landscape oriented they are placed above. The first
> is the bigger nuisance, the latter just mildly distracting.

But we cannot generalize this, because there may of course be quadratic photos
in an album. But this should then be solved for you with an option to remove
the overlays.

> Regarding the border, I don't understand why the border is painted whenever I
> touch an image by passing the mouse over it but it (the border) isn't removed
> after the mouse left the active area - scrolling the list does remove the
> border :-(...

Hm, that sounds like a different problem. The border should be static. Can you
provide some screenshots?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.