[Digikam-devel] [Bug 132079] Support for editing non-local files

Johannes Wienke languitar at semipol.de
Thu Nov 5 23:25:15 GMT 2009


https://bugs.kde.org/show_bug.cgi?id=132079





--- Comment #12 from Johannes Wienke <languitar semipol de>  2009-11-06 00:25:03 ---
Created an attachment (id=38127)
 --> (http://bugs.kde.org/attachment.cgi?id=38127)
patch to enable remote saving of raw files

Gilles, Andi

This patch enables remote saving also for raw files. To fix this I refactored a
big part of the saving method. Could you please check that I didn't break
anything?

Some things to notice:
- The file dialog was initialized with filters and afterwards it was tried to
read mime information. This isn't possible as the api documentation said and
never worked. So there was a fall back to the other variants for determining
the target file format.
- Remote saving didn't succeed for raw files, because the first fall back
method tried to get the extension of the target url to determine the format and
used QFileInfo for that purpose. However this only works for local files. So I
added string manipulation for local files to extract the extension
- Because the above check didn't work for remote methods, the format of the
source file was taken (which could be raw). Unfortunately this wasn't checked
against the writeable formats. So I added this check to avoid writing RAW
format.
- I've removed the KImageIO filter "all image types" from the dialog, because
this doesn't clearly allow to determine the desired format from the filter,
which also means that special format options could not be displayed.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Digikam-devel mailing list