[Digikam-devel] Strange crashes

[Gilles Caulier]

Andi,

please try my commit #971243...

Gilles

2009/5/22 Gilles Caulier <caulier.gilles at gmail.com>:
> Ok. i think the problem come from this commit :
>
> http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/threadimageio/thumbnailcreator.cpp?r1=965516&r2=965524
>
> Gilles
>
> 2009/5/21 Matthias Welwarsky <matze at welwarsky.de>:
>> On Thursday 21 May 2009 19:44:55 Gilles Caulier wrote:
>>> And yes, GwenView use ::rename too !
>>>
>>> http://lxr.kde.org/source/KDE/kdegraphics/gwenview/lib/thumbnailloadjob.cpp
>>>#249
>>
>> Looking at that code, isn't the temporary file created in the same directory
>> and then just renamed?
>>
>>> Gilles
>>>
>>> 2009/5/21 Gilles Caulier <caulier.gilles at gmail.com>:
>>> > 2009/5/21 Matthias Welwarsky <matze at welwarsky.de>:
>>> >> On Thursday 21 May 2009 19:16:46 Matthias Welwarsky wrote:
>>> >>> On Thursday 21 May 2009 18:40:29 Marcel Wiesweg wrote:
>>> >>> > > Have you deleted / renamed your ~/.thumbnails folder?
>>> >>> > > Already generated thumbnails from the past (before the KDE::rename
>>> >>> > > patches) are working perfectly fine here, too.
>>> >>> > >
>>> >>> > > What happens when you rename the thumbnails folder so that all
>>> >>> > > thumbs are really generated new?
>>> >>> > >
>>> >>> > > I always get
>>> >>> > > digikam(7372)/digikam (core) Digikam::ThumbnailCreator::load:
>>> >>> > > Cannot rename thumb file (
>>> >>> > > "/tmp/kde-andi/415adced8a4644d971d5c6706c2abc90-digikam-
>>> >>> > > wS7372.png" ) digikam(7372)/digikam (core)
>>> >>> > > Digikam::ThumbnailCreator::load: to (
>>> >>> > > "/home/andi/.thumbnails/large/415adced8a4644d971d5c6706c2abc90.png"
>>> >>> > > )...
>>> >>> > >
>>> >>> > > My /tmp is on my root partition (ext4), /home is reiserfs.
>>> >>> > > I also changed /tmp to be the tmpfs (so that it is a ramdisk
>>> >>> > > actually), but still the same error.
>>> >>> >
>>> >>> > I can confirm this. New thumbnails are not stored. The error messages
>>> >>> > as above appear. /tmp is on a different partition than /home, both
>>> >>> > ext4.
>>> >>>
>>> >>> Ah. So the rename is not working across file systems :-) Maybe because
>>> >>> it uses rename(2)? Take a look at the man page.
>>> >>
>>> >> Yup, that's it. KDE_rename is just "#define KDE_rename ::rename". That
>>> >> one cannot safely be used to move files around.
>>> >
>>> > Well, why it's work with dolphin and konqueror ?
>>> >
>>> > Gilles
>>> >
>>> >>> _______________________________________________
>>> >>> Digikam-devel mailing list
>>> >>> Digikam-devel at kde.org
>>> >>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>> >>
>>> >> _______________________________________________
>>> >> Digikam-devel mailing list
>>> >> Digikam-devel at kde.org
>>> >> https://mail.kde.org/mailman/listinfo/digikam-devel
>>>
>>> _______________________________________________
>>> Digikam-devel mailing list
>>> Digikam-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>> _______________________________________________
>> Digikam-devel mailing list
>> Digikam-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/digikam-devel
>>
>