[Digikam-devel] extragear/graphics/digikam/utilities

[Andi Clemens]

SVN commit 997148 by aclemens:

Fullscreen is a toggle action and should be used as such.
Either press the button in the toolbar, or CTRL+SHIFT+F to exit
fullscreen.
This mechanism is used throughout KDE and should be used in digiKam as
well of course.
I would strongly recommend NOT to use ESC to quit the fullscreen mode.

I disable these actions for now, but again I would rather remove it
completely. What do you think?

Andi

CCMAIL:digikam-devel at kde.org

 M  +4 -4      cameragui/cameraui.cpp  
 M  +4 -4      lighttable/lighttablewindow.cpp  
 M  +4 -4      queuemanager/queuemgrwindow.cpp  


--- trunk/extragear/graphics/digikam/utilities/cameragui/cameraui.cpp #997147:997148
@@ -489,10 +489,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("cameraui_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
     actionCollection()->addAction("cameraui_backward_shift_space", altBackwardAction);
--- trunk/extragear/graphics/digikam/utilities/lighttable/lighttablewindow.cpp #997147:997148
@@ -550,10 +550,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     KAction *altBackwardAction = new KAction(i18n("Previous Image"), this);
     actionCollection()->addAction("lighttable_backward_shift_space", altBackwardAction);
--- trunk/extragear/graphics/digikam/utilities/queuemanager/queuemgrwindow.cpp #997147:997148
@@ -445,10 +445,10 @@
 
     // -- Keyboard-only actions added to <MainWindow> ------------------------------
 
-    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
-    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
-    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
-    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
+//    KAction *exitFullscreenAction = new KAction(i18n("Exit Fullscreen mode"), this);
+//    actionCollection()->addAction("editorwindow_exitfullscreen", exitFullscreenAction);
+//    exitFullscreenAction->setShortcut( QKeySequence(Qt::Key_Escape) );
+//    connect(exitFullscreenAction, SIGNAL(triggered()), this, SLOT(slotEscapePressed()));
 
     // ---------------------------------------------------------------------------------