[Digikam-devel] [Bug 205776] "Embedded preview loads full image size" does not only do what it says, confusing users

[Matti Rintala]

https://bugs.kde.org/show_bug.cgi?id=205776





--- Comment #5 from Matti Rintala <bitti cs tut fi>  2009-08-31 15:25:03 ---
Gilles,

I'm ready to try to make a patch (I'm not very familiar with Digikam source,
but after a quick look I think I can learn enough as I go). However, there's a
couple of design decision that should be made and I'm not the right person to
make them:

What kind of GUI should the new setting have? There are at least three choices
I can think of:
- A new checkbox for selecting raw-decoding vs. embedded preview for raw files
("use embedded preview for raw files")
  + Easiest to implement
  + Most backward compatible
  - Adds yet another user preference
  - Combination not-full-size & no-embedded probably not useful (and difficult
to implement in current source)
- Similar to above, but raw-decoding selection is grayed out if full-size is
not selected (reduced-size preview always uses embedded preview if available)
  + Solves the combination problem above
  - I'm not experienced enough with KDE GUI programming to write the GUI logic
- A single radio button / dropdown list for selecting fullsize-raw,
fullsize-embedded and reduced-size-embedded
  + Changes the user preference from a boolean to a three-state value
  - Above makes it less backward compatible? (Old 0.10.0 preference files?)

In any of the cases above, on the source level there will be changes to the
interface of several classes, since current preview classes explicitly name the
member functions "...LoadFullImageSize...", so using existing member functions
to select raw/embedded-jpg is not appropriate in my opinion. Either new methods
"...LoadEmbeddedPreview..." should be added or the current methods should be
renamed "...PreviewQuality..." or something similar.

Any opinions before I try to mess up the source? :-)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.