[Digikam-devel] extragear/graphics/digikam

Andi Clemens andi.clemens at gmx.net
Sat Aug 8 10:37:05 BST 2009


SVN commit 1008744 by aclemens:

Remove button & toolMask from the EditorToolSettings constructor.
It was confusing to set a HistogramType, even if no histogram tool was
requested.
Also the constructor was not readable, the toolcodes and the buttoncodes
where visually mixed together, it was hard to distinguish.

Another problem was that you couldn't change the settings if ever needed
to, since the parameters were only set in the constructor.

EditorToolSettings has the following default layout now:
Buttons: Default, Ok, Cancel
Tools: None

If more buttons or tools are needed, you can use the setter methods:

setButtons(Ok|Cancel|Default|Try|Load|Save);
setTools(None|ColorGuide|PanIcon|Histogram);

An additional setter method for the histogram has been added, to change
the type of the HistogramBox:

setHistogramType(HistogramBox::HistogramType);

CCMAIL:digikam-devel at kde.org

 M  +9 -7      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +9 -7      imageplugins/adjustlevels/adjustlevelstool.cpp  
 M  +7 -5      imageplugins/blurfx/blurfxtool.cpp  
 M  +1 -3      imageplugins/border/bordertool.cpp  
 M  +9 -7      imageplugins/channelmixer/channelmixertool.cpp  
 M  +7 -5      imageplugins/charcoal/charcoaltool.cpp  
 M  +2 -5      imageplugins/colorfx/colorfxtool.cpp  
 M  +5 -4      imageplugins/contentawareresizing/contentawareresizetool.cpp  
 M  +2 -4      imageplugins/coreplugin/autocorrectiontool.cpp  
 M  +2 -5      imageplugins/coreplugin/bcgtool.cpp  
 M  +2 -4      imageplugins/coreplugin/blurtool.cpp  
 M  +8 -6      imageplugins/coreplugin/bwsepiatool.cpp  
 M  +2 -5      imageplugins/coreplugin/hsl/hsltool.cpp  
 M  +8 -6      imageplugins/coreplugin/iccprooftool.cpp  
 M  +5 -4      imageplugins/coreplugin/ratiocrop/ratiocroptool.cpp  
 M  +2 -4      imageplugins/coreplugin/redeyetool.cpp  
 M  +10 -9     imageplugins/coreplugin/resizetool.cpp  
 M  +2 -4      imageplugins/coreplugin/rgbtool.cpp  
 M  +10 -7     imageplugins/coreplugin/sharpentool.cpp  
 M  +2 -4      imageplugins/distortionfx/distortionfxtool.cpp  
 M  +2 -4      imageplugins/emboss/embosstool.cpp  
 M  +2 -4      imageplugins/filmgrain/filmgraintool.cpp  
 M  +2 -4      imageplugins/freerotation/freerotationtool.cpp  
 M  +5 -4      imageplugins/hotpixels/hotpixelstool.cpp  
 M  +2 -4      imageplugins/infrared/infraredtool.cpp  
 M  +7 -6      imageplugins/inpainting/inpaintingtool.cpp  
 M  +1 -3      imageplugins/inserttext/inserttexttool.cpp  
 M  +1 -3      imageplugins/lenscorrection/autocorrection/autocorrectiontool.cpp  
 M  +2 -4      imageplugins/lenscorrection/distortion/lensdistortiontool.cpp  
 M  +1 -3      imageplugins/lenscorrection/vignetting/antivignettingtool.cpp  
 M  +12 -7     imageplugins/localcontrast/localcontrasttool.cpp  
 M  +9 -7      imageplugins/noisereduction/noisereductiontool.cpp  
 M  +7 -5      imageplugins/oilpaint/oilpainttool.cpp  
 M  +2 -4      imageplugins/perspective/perspectivetool.cpp  
 M  +5 -4      imageplugins/raindrop/raindroptool.cpp  
 M  +9 -7      imageplugins/restoration/restorationtool.cpp  
 M  +2 -4      imageplugins/sheartool/sheartool.cpp  
 M  +1 -3      imageplugins/superimpose/superimposetool.cpp  
 M  +2 -4      imageplugins/texture/texturetool.cpp  
 M  +8 -6      imageplugins/whitebalance/whitebalancetool.cpp  
 M  +47 -42    utilities/imageeditor/editor/editortoolsettings.cpp  
 M  +10 -2     utilities/imageeditor/editor/editortoolsettings.h  
 M  +5 -2      utilities/imageeditor/rawimport/rawsettingsbox.cpp  


http://websvn.kde.org/?view=rev&revision=1008744



More information about the Digikam-devel mailing list