[Digikam-devel] Blur-Tool

[Gilles Caulier]

2009/4/13 Andi Clemens <andi.clemens at gmx.net>:
>
> On Monday 13 April 2009 15:56:51 Gilles Caulier wrote:
>> 2009/4/13 Andi Clemens <andi.clemens at gmx.net>:
>> > If CImg works fine here, the blur filter doesn't need to be a
>> > ThreadedFilter anymore... Right?
>>
>> No. all filters need to use an outside thread to run. and it's yet the
>> case, for example with levels or curves tools.
>>
>> > Andi
>> >
>> > On Monday 13 April 2009 15:47:59 Andi Clemens wrote:
>> >> Hi,
>> >>
>> >> as far as I see this, we are using a normal gaussian blur in the blur
>> >> tool. The problem with our own algorithm: it is damn slow.
>>
>> Yes, i know the problem... Algorithm is not mine, it come from a
>> Bresilien mathematician. (:=)))
>>
>> >> I just played around with the CImg::blur() method and it is like 20
>> >> times faster, with an (at least for me) equal result.
>>
>> It's a Gaussian blur like ?
>
> Yes
>
>> >> If we are going to use CImg in more plugins, we should add some classes
>> >> to DImg to easily convert between the two storage formats.
>>
>> yes. Code to convert DImg <-> CImg is already in greystorationiface.cpp
>
> I meant: we should add some methods to the DImg class, not classes to DImg :-)

yes. i have understood.

Just take code from greystorationiface.cpp, extend DImg with it and factorize...

Gilles