[Digikam-devel] [Bug 167873] Tag and album trees are not expanded when searching for entries

[Andi Clemens]

http://bugs.kde.org/show_bug.cgi?id=167873


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #20 from Andi Clemens <andi clemens gmx net>  2008-11-04 16:31:45 ---
SVN commit 880037 by aclemens:

collapse children of matching album / tag names.

If an album name matches the filter in one of the children of the current item,
but not the current item's own name,
don't expand the current item.
This will prevent the following situation. Assume we have this album layout:

|-- 1999
|   |-- Alleyras
|   `-- Test
|       |-- 01
|       `-- 02
`-- 2008
    `-- all
        |-- 01
        `-- 02

When we search for the term all, we will get this layout with the old behavior:

|-- 1999
|   |-- Alleyras
`-- 2008
    `-- all
        |-- 01
        `-- 02

But this is wrong and can get quite messy if you have heavy nested folders. We
should only display the folder names that really match the term.
We can either do this by removing all folders that don't match the criteria,
but this is bad. Assume we search for "birthday" and want to see the underlying
folders.
With this method they'll be gone. So the only other possible way is to collapse
all non matching children like this:

|-- 1999
|   |-- Alleyras
`-- 2008
    `-- all

You still can expand the folder 'all' to get the sub-folders, but they will not
mess up the folder view anymore.
Ok this was a long description for a commit... :-)

Andi

BUG:167873

 M  +4 -2      digikam/albumfolderview.cpp  
 M  +3 -1      digikam/tagfilterview.cpp  
 M  +4 -2      digikam/tagfolderview.cpp  
 M  +3 -1      libs/imageproperties/imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=880037


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.