[Digikam-devel] [Bug 162113] "set as background" does not fully escape filenames

[John Calixto]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=162113         




------- Additional Comments From john calixto net  2008-05-15 08:01 -------
With strace, I found the following errors when trying to set the
background:

    [pid  8172] write(2, "/bin/sh: ", 9)    = 9
    [pid  8172] write(2, "Syntax error: Unterminated quote"..., 40) = 40

Further investigation with strace revealed that digikam uses dcop to
set the background image - something to the effect of:

    dcop kdesktop KBackgroundIface setWallpaper ...

I'm not sure if this is the correct place for the fix, but I found
the following code in imageviewer.cpp:

        QString com=QString("dcop kdesktop KBackgroundIface setWallpaper '%1' %2 >/dev/null 2>/dev/null")
                                .arg(m_loaded_image_url.url())

The problem seems pretty obvious from that snippet.  I'll try and
submit a patch later.