[Digikam-devel] [Bug 152877] thumbnails: URI does not follow Thumbnail Managing Standard

Gilles Caulier caulier.gilles at gmail.com
Fri Dec 5 08:02:40 GMT 2008


http://bugs.kde.org/show_bug.cgi?id=152877





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2008-12-05 09:02:39 ---
I found the problem from digiKam thumb creator. Look this code :

http://websvn.kde.org/branches/extragear/kde3/graphics/digikam/kioslave/digikamthumbnail.cpp?view=markup

At line 132, you can see:

QString uri = "file://" + QDir::cleanDirPath(url.path(-1));

uri is set as embeded text to png file with line 197:

img.setText(QString("Thumb::URI").latin1(), 0, uri);

Sound like the problem is at line 132 with QDir::cleanDirPath() method.

Now compare with KDE KIO thumb creator:

http://websvn.kde.org/branches/KDE/3.5/kdelibs/kio/kio/previewjob.cpp?revision=496090&view=markup

at line 505, url is recorded to png file as digiKam:

thumb.setText("Thumb::URI", 0, d->origName);

and at line 384, method statResultThumbnail() do not use QDir::cleanDirPath()

Andi, Marcel, your viewpoints ?

Note : this report is very important because if we fix it, it will speed up
thumbnails rendering with non-latin file paths.

Gilles


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Digikam-devel mailing list