andi.clemens at gmx.net
Mon Dec 1 20:41:44 GMT 2008
Somehow I'm not sure if it really fixes the splitter problems... I had the
issue just 2 minutes ago... AGAIN!
Now I don't know if I had messed up my digikamrc file or if it is the same old
bug we are hunting for moths now.
I will not commit it and test it a little more. Next I will convert from KDE3
to KDE4, it should fail then...
I will keep you informed.
On Monday 01 December 2008 21:21:50 Andi Clemens wrote:
> On Monday 01 December 2008 21:13:38 Marcel Wiesweg wrote:
> > > Marcel, any comment on why we use toBase64() methods to save splitter
> > > state? Otherwise I will commit the changes to SVN, for me it works fine
> > > in my GIT repo, even with "broken" digikamrc files.
> > >
> > > Andi
> > We get raw binary data from QSplitter, and use toBase64 to encode it to
> > ASCII to store it in the config file. We use toBase64 before we store to
> > KConfig and use fromBase64 after reading from KConfig.
> > I dont know any more where we took that from or if I made this up myself,
> > and I dont know if this is strictly necessary. Possibly KConfig can
> > perfectly well store raw binary data.
> > If you can confirm that bugs are caused by this and after removal the
> > problems are solved, and configuration is always saved, then please
> > commit. (Keep in mind that when you remove fromBase64 the "broken"
> > digikamrc files will fail to load at all.)
> No, they load perfectly... I assume that the SplitterState config vars will
> not be read at all (because they are unknown now) and the default values
> will be used. After closing digiKam, the new SplitterState will be saved.
> OK I will commit it then...
> > Marcel
> > _______________________________________________
> > Digikam-devel mailing list
> > Digikam-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/digikam-devel
> Digikam-devel mailing list
> Digikam-devel at kde.org
More information about the Digikam-devel