[Digikam-devel] Preview behaviour

[Mikolaj Machowski]

Dnia Thursday 17 of April 2008, Arnd Baecker napisał:
> Hi Mikolaj,
>
> thanks a lot for testing, some comments below:
>
> On Thu, 17 Apr 2008, Mikolaj Machowski wrote:
> > Dnia Thursday 17 of April 2008, Arnd Baecker napisał:
> > > Hi,
> > >
> > > there are a couple of small issues, which nag me for a while:
> > >
> > > a) CTRL+ALT+0 should behave as a toggle between
> > >    fit-to-window and 100% zoom
> > >    (also for the light-table and image-editor)
> >
> > Works, thanks.
> >
> > > b) the slider should "snap" to 100% when one is in the range
> > >    95% < x < 105%
> >
> > Works, thanks. But IMO this should go further: snapping should work
> > also zoom factors: fit into window; fit width; fit height. But it
> > would require to compute snapping factors for each image separately.
>
> Ok, this wish makes sense. However, it is
> not that easy to implement. So I would suggest that this
> should be filed as a separate wish in the BKO.

It works in gwenview and KPDF. You can look there.

> > Another place where "snapping" could help are zoom buttons: when
> > clicking on them it should stop not only on apparently random chosen
> > steps but also: fit to window; fit width; fit height; 100%. It should
> > work in all appropriate places: preview mode, lighttable, Image
> > Editor.
>
> Not sure that I understand...
> Would you like to have additional buttons?

Definitely no! Example: slider is on 90% zoom factor, if I use now
+zoom button it will jump to 108% - it should jump to 100%. Everytime
- now it works from time to time.

> > One case where your patch creates problems. When browsing in preview
> > mode with option of full size preview turned off digiKam uses some
> > "virtual thumbnails". Their size (at least in my testing case) is very
> > similar to size of screen. It means that 'fit to window' size of
> > preview oscillates around 90-100% and your patch enforces 100% of zoom
> > making images larger than preview area. This is really uncomfortable.
>
> Hmm, but that's how a 100% view has to look
> (because of the "virtual thumbnail" size). I don't think
> my patch can be blaimed here ... ;-)

;)

> > Problem
> > vanishes when using option "Albums->Embedded preview load full image
> > size". I hope I am clear...
>
> Yes, absolutely. Personally I  only use
> "Albums->Embedded preview load full size".
>
> > It highlights two problems: 1) when reporting zoom in preview digiKam
> > should report zoom of real image.
>
> Yes. This also needs a separate entry in the BKO.
>
> > 2) your patch should differentiate
> > between slider/zoom button action and real 'fit to window'.
>
> I don't see this as the intended feature of this *small* patch
> (but maybe I don't understand what you propose ...;-)
> It just does
> - make CTRL+ALT+0 a toggle
> - snap to 100% for the slider

Not only. Looks like it forces 100% zoom every time image is close to it.

m.