[Digikam-devel] [Bug 96894] Wish: easier navigation between albums, tags and collections

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=96894         
arnd.baecker web de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21695|0                           |1
        is obsolete|                            |
  Attachment #21698|0                           |1
        is obsolete|                            |



------- Additional Comments From arnd.baecker web de  2007-09-27 11:15 -------
Created an attachment (id=21701)
 --> (http://bugs.kde.org/attachment.cgi?id=21701&action=view)
also allow goto tag

Mikolaj, thanks a lot for testing!

1/ Of course you are right! Still I think that "Go to" would be even better.
OK?
   (Actually the same in the menu below: "Open With" -> "Open with")
2/ I had a look at it, implemented apart from one problem, 
    see my technical question below.
   (However, I think adding a submenu is technically simpler, well,
    let's first get the functionality working)
3/ I tried a couple of cases, but it seems to work fine here.
   So presumably I am using a different ordering. 
   Could you describe a sequence in which this happens
   (Actually, I was about to ask, what is the "strange place", 
    i.e. a different folder or a wrong image, but then your previous
    message arrived.)
    Hmm, so this needs further debugging find out a reproducible
    scheme for this issue...

   However, what I do observe is that when going to a Date view,
   there is an empty entry in the history for the Back/Forward
   entries. Note that this also happens without the patch.
   I.e., this is a different bug ;-).

I also just realized, that goto was even possible when more
than one item is selected. In this case I disable the goto menu. OK?

Now the technical question for Gilles concerning /2:

I use TagsPopupMenu::REMOVE for this purpose:

TagsPopupMenu* gotoTagsPopup = new TagsPopupMenu(selectedImageIDs, 1000,
TagsPopupMenu::REMOVE);
int gotoTagId = gotoMenu.insertItem(i18n("Tag"), gotoTagsPopup);

connect(gotoTagsPopup, SIGNAL(signalTagActivated(int)),
				   this, SLOT(slotGotoTag(int)));

In the new routine 
  void AlbumIconView::slotGotoTag(int tagID)
I would like to 
  emit signalGotoTagAndItem(tagID, iconItem);
but I don't have the iconItem at hand.

Is there a simple way to pass the iconItem through via the connect?

Another important point: 
In slotGotoTag I need the 
  void selectItem(int id);
from tagfolderview.cpp, however it is defined in protected.
Is it ok to move it into public, or
should a different approach be used?
(It seems to work though ...;-)

Thanks, Arnd