[Digikam-devel] [Digikam-users] digiKam 0.9.3 release cycle

[Arnd Baecker]

On Tue, 30 Oct 2007, Marcel Wiesweg wrote:

> > > There are a couple of bugs with patches, which could go
> > > into the next beta, after review:
> > >
> > > - "Search for non-voted pics"
> > >   http://bugs.kde.org/show_bug.cgi?id=147426
> > >   Marcel, could you have a look at the patch?
> >
> > Marcel,
> >
> > I have review this patch for KDE3 and it sound fine for me...
> >
> > but Rating information place have changed in DB for KDE4, and this patch
> > must be adapted.Can you take a look ?
>
> The rating has now a real place in db, this means that every image is
> initialized with whatever DMetadata::getImageRating returns, which is -1 when
> no information is found.
> Currently in the UI a rating of 0 is treated like a rating of -1, and maybe
> this is right so. (a matter of definition)
> So in 0.10, searching for "no rating" would mean searching for -1 and/or 0.

Sor for the patch at
http://bugs.kde.org/show_bug.cgi?id=147426
the logic to be considered for 0.10  are the cases:

a) For val = 0:
   i)   >= 0  corresponds to search for >=-1
        I.e, choose:  val = -1, op = GTE
   ii)  == 0  corresponds to search for ==0 or == -1
        I.e, choose: val = 0, op = LTE
   iii) <= 0  corresponds to search for ==0 or == -1
        i.E. choose val = 0, op = LTE
b) For val >0:
   <  val
   <= val
   != val
So case b) does not need any special treatment anymore
as -1 < 0 ;-).

Best, Arnd