[Digikam-devel] [Bug 151357] Ratings can exceed 5 stars

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=151357         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|general                     |Albums GUI
         Resolution|                            |FIXED



------- Additional Comments From arnd.baecker web de  2007-10-26 07:50 -------
Hi Mark,

thanks for the report! I can reproduce and it seems simple
to fix, compile is running...
(note: B.K.O web-interface  seems broken, so I don't know
when I can attach the fix - if the fix works ;-)

Best, Arnd


------- Additional Comments From arnd.baecker web de  2007-10-26 08:08 -------
Created an attachment (id=21914)
 --> (http://bugs.kde.org/attachment.cgi?id=21914&action=view)
ensure rating<=5 when dragging with the mouse

In RatingWidget::mouseMoveEvent it was possible to generate
values >=5 for the position of the mouse (values < 0 are not possible
as the mouse position is always >=0). This
value was directly used as d->rating.
The attached patch ensures that pos<=RatingMax.

------- Additional Comments From arnd.baecker web de  2007-10-26 18:52 -------
SVN commit 729686 by abaecker:

Ensure that rating cannot be larger than RatingMax when dragging the mouse.

CCBUGS: 151357
TODO:KDE4PORT



 M  +2 -1      NEWS  
 M  +2 -0      digikam/ratingwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=729686


------- Additional Comments From arnd.baecker web de  2007-10-26 19:15 -------
SVN commit 729699 by abaecker:

Ensure that rating cannot be smaller than RatingMin when dragging the mouse.

CCBUGS: 151357
TODO:KDE4PORT



 M  +2 -0      ratingwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=729699


------- Additional Comments From caulier.gilles gmail com  2007-10-30 08:23 -------
patch backported to KDE4. I close this file now.

Gilles Caulier