[Digikam-devel] [Bug 128231] A way to view pictures recursively in albums and sub-albums at the same time would be cool

[Antonio E.]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=128231         




------- Additional Comments From aironmail gmail com  2007-11-20 23:33 -------
Well, it's ready. I had a little problem applying the patch (after updating the svn), in particular for the file digikam/albumsettings.cpp. The rejected piece is:

cat digikam/albumsettings.cpp.rej
***************
*** 177,183 ****
                                    "*.png *.gif *.bmp *.xpm *.ppm *.pnm *.xcf *.pcx";

      d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
-                                 "*.avi *.mov *.wmf *.asf *.mp4";

      d->defaultAudioFilefilter   = "*.ogg *.mp3 *.wma *.wav";

--- 179,185 ----
                                    "*.png *.gif *.bmp *.xpm *.ppm *.pnm *.xcf *.pcx";

      d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
+                                   "*.avi *.mov *.wmf *.asf *.mp4";

      d->defaultAudioFilefilter   = "*.ogg *.mp3 *.wma *.wav";



As you see something really minour, caused because the latest svn version includes the addition of '*.3gp' in the movie filters, so the lines are:

    d->defaultMovieFilefilter   = "*.mpeg *.mpg *.mpo *.mpe "         // MPEG
                                  "*.avi *.mov *.wmf *.asf *.mp4 *.3gp";


Well, that was the only patching problem, I checked manually that the rest was OK.

Now the testing. I found the two toggle buttons that you have mentioned.

When turning on "Include Album Sub-Tree", it displayes correctly the subalbums. They're correctly listed when sorting by date of by name.

The option that I think that doesn't work is the one about the Include Tag Sub-Tree.

I have the albums:

Album1
+SubAlbum1

And the Tags:
Tag1
+SubTag1

In Album1 I apply SubTag1 to one image.
In SubAlbum1 I apply SubTag1 to one image and Tag1 to another.

Experiment 1:
- I click in SubAlbum1 to display its images. I turn on the "Include Tag Sub-Tree" and I keep disabled the "Include Album Sub-Tree" option.
- I select Tag1.
Result: Only one image is displayed, the one tagged with Tag1, but no the other one with SubTag1.
Expected: Two images listed, one tagged with Tag1 and another with SubTag1.

Experiment 2:
- I click on the same album (SubAlbum1)
- I select the two tags.
Result: All tagged images are displayed.

Experiment 3:
- I click on Album1.
- I select SubTag1.
- I turn on the two toggle buttons.
Result: The two tagged images with SubTag1 are listed.

Experiment 4:
- I click on Album1.
- I select Tag1.
- I turn on the two toggle buttons.
Result: Only one image is displayed, the one tagged with Tag1.
Expected: Three images, the one tagged with Tag1 and the two ones tagged with SubTag1.


So, there are some problems displaying recursively the sub tags. But for the sub albums, without using tags, everything works nicely.