[Digikam-devel] [Bug 150801] Thumbnail and image view does not update after editing image

[Paweł Marciniak]

Gilles Caulier wrote:

> Thanks to point me over this problem... but libkexiv2 is not the right
> place to fix it.
> 
> The bug is in editor... Look at this file:

You're right - That solves it. I must have missed that place.

But don't you think it would be better to remove the preview only if it
really is > 64 KiB? Many of my png files (blue sky etc. ;)) have preview
that fits in JPEG tag and I presume it's always good to preserve it. I mean
something like:


// Optimistically update IPTC preview
meta.setImagePreview(preview);

if ( mimeType.upper() == QString("JPG") || mimeType.upper() ==
QString("JPEG") || mimeType.upper() == QString("JPE"))
{
    if (meta.getIptcTagData("Iptc.Application2.Preview").size() > 65536)
    {
        // JPEG file, we remove too big IPTC preview.
        meta.removeIptcTag("Iptc.Application2.Preview");
        meta.removeIptcTag("Iptc.Application2.PreviewFormat");
        meta.removeIptcTag("Iptc.Application2.PreviewVersion");
    }
}


What do you think?

Pawel