[Digikam-devel] [Bug 141730] page down/up goes to next/previous picture istead of scolling a page

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=141730         




------- Additional Comments From arnd.baecker web de  2007-11-02 11:10 -------
Created an attachment (id=21981)
 --> (http://bugs.kde.org/attachment.cgi?id=21981&action=view)
Make PageUp/PageDown  move by screen pages in the album view

OK, we also discussed this issue on the IRC yesterday,
and the conclusion is:

- comment #1 is not confirmed.
- PageDown/PageUp should do what they say ;-)
- In Preview mode: PageDown/CursorRight and PageUp/CursorLeft should
  go to the previous/next item.

When looking at the code I did at first not understand, why
CTRL+PageDown did the expected and PageDown
did just go to the next item
(routine void IconView::keyPressEvent(QKeyEvent* e)).
It turned out that in void DigikamApp::setupAccelerators()
Key_Next and Key_Prior are bound to signalNextItem() and signalPrevItem() !
so only if CTRL is pressed, it gets through to void
IconView::keyPressEvent(QKeyEvent* e).

This explains the approach taken in the attached patch:
a) in void DigikamApp::setupAccelerators() bind Key_Right and Key_Left
   to signalNextItem() and signalPrevItem()
b) Don't bind PageDown/PageUp (i.e. Key_Next, Key_Prev) in 
   DigikamApp::setupAccelerators()
c) a new void ImagePreviewView::keyPressEvent(QKeyEvent* e)
   to bind Key_PageDown and Key_PageUp in the preview mode.

However, c) does not work, i.e. the routine keyPressEvent is
never called.
So presumably this is the wrong approach/not done correctly.

Ideas how to solve this last bit are welcome!