[Digikam-devel] [Bug 146012] dragging an image over a tag in "tag filters" pane crashes digikam

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=146012         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2007-05-27 10:09 -------
SVN commit 668672 by cgilles:

digiKam from trunk : Fix crash on Tags Filter view when item is moved under "Not Tagged" item.
BUG: 146012


 M  +13 -6     tagfilterview.cpp  


--- trunk/extragear/graphics/digikam/digikam/tagfilterview.cpp #668671:668672
 @ -404,13 +404,20  @
         return true;
     }
 
-    if (ItemDrag::canDecode(e) && itemDrop && 
-        itemDrop->m_tag->parent() && !itemDrop->m_untagged)
+    if (ItemDrag::canDecode(e) && itemDrop && !itemDrop->m_untagged)
     {
-        // Only other possibility is image items being dropped
-        // And allow this only if there is a Tag to be dropped
-        // on and also the Tag is not root or "Not Tagged" item.
-        return true;
+        TAlbum *tag = itemDrop->m_tag;
+        
+        if (tag)
+        {
+            if (tag->parent())
+            {         
+                // Only other possibility is image items being dropped
+                // And allow this only if there is a Tag to be dropped
+                // on and also the Tag is not root or "Not Tagged" item.
+                return true;
+            }
+        }
     }
 
     return false;