[Digikam-devel] [Bug 142443] red eye correction should change eye colour to an alternate colour

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=142443         




------- Additional Comments From caulier.gilles gmail com  2007-03-06 12:36 -------
SVN commit 639957 by cgilles:

digikam from trunk : first approach to use a blending level to merge coloring taint in red eyes correction tool. level hardcoded to 64 give good result, but a clean tool dialog with a slider and a preview look better to set this parameter to the right value.

Photographers : please, i need pictures with Red Eyes face to test. Please send me some samples files by private mail (caulier dot gilles at gmail dot com). Thanks in advance...

CCBUGS: 142443




 M  +4 -3      imageeffect_redeye.cpp  


--- trunk/extragear/graphics/digikam/imageplugins/imageeffect_redeye.cpp #639956:639957
 @ -144,14 +144,15  @
     blue_chan.blue_gain   = 1.0;
 
     float red_norm, green_norm, blue_norm;
+    int   level = 64;
 
     red_norm   = 1.0 / (red_chan.red_gain   + red_chan.green_gain   + red_chan.blue_gain);
     green_norm = 1.0 / (green_chan.red_gain + green_chan.green_gain + green_chan.blue_gain);
     blue_norm  = 1.0 / (blue_chan.red_gain  + blue_chan.green_gain  + blue_chan.blue_gain);
 
-    red_norm   *= coloring.red();
-    green_norm *= coloring.green();
-    blue_norm  *= coloring.blue();
+    red_norm   *= coloring.red()   / level;
+    green_norm *= coloring.green() / level;
+    blue_norm  *= coloring.blue()  / level;
 
     if (!selection.sixteenBit())         // 8 bits image.
     {