[Digikam-devel] [Kde-imaging] extragear/libs

Caulier Gilles caulier.gilles at kdemail.net
Fri Jan 26 18:14:04 GMT 2007


Le Vendredi 26 Janvier 2007 18:20, Tom Albers a écrit :
> Op vr 26 jan 2007 18:09 schreef u:
> > On Friday, 26. January 2007 15:06, Angelo Naselli wrote:
> > > Alle 13:55, venerdì 26 gennaio 2007, Gilles Caulier ha scritto:
> > > > SVN commit 627390 by cgilles:
> > > >
> > > > New common library witch will be used by digiKam and kipi-plugins to
> > > > handle
> >
> > Pictures metadata (Exif/Iptc).
> >
> > > > This shared library is a wrapper around Exiv2 library. It give a Qt
> > > > like
> >
> > interface to control
> >
> > > > Exiv2 actions on pictures. Using this library will remove all
> > > > duplicate
> >
> > code on kipi-plugins::exiv2iface and
> >
> > > > digikam::dmetadata.
> > > >
> > > > The current implementation is the same than kipi-plugins/exiv2iface.
> > > > This
> >
> > library is not yet used in digiKam/kipi-plugins.
> >
> > > > We will added a new depency to this library in kipi-plugins in first
> > > > and
> >
> > later to digiKam.
> >
> > > > CCMAIL: digikam-devel at kde.org, kde-imaging at kde.org,
> > > > marcel.wiesweg at gmx.de
> > > >
> > > >
> > > >
> > > >  A             libkexiv2 (directory)
> > > >  A             libkexiv2/AUTHORS
> > > >  A             libkexiv2/COPYING
> > > >  A             libkexiv2/ChangeLog
> > > >  A             libkexiv2/INSTALL
> > > >  A             libkexiv2/Makefile.am
> > > >  A             libkexiv2/NEWS
> > > >  A             libkexiv2/README
> > > >  A             libkexiv2/configure.in.in
> > > >  A             libkexiv2/exiv2iface.cpp
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.cpp#627389
> >
> > > >  A             libkexiv2/exiv2iface.h
> >
> > kipi-plugins/common/exiv2iface/exiv2iface.h#627389
> >
> > > >  A             libkexiv2/libkexiv2.lsm
> > > >  A             libkexiv2/libkexiv2.pc.in
> > > >  A             libkexiv2/libkexiv2_export.h   [License: LGPL (v2+)
> > > > (wrong
> >
> > address)]
> >
> > > Are you sure that is the right way to? In such a way we removed
> > > libkexif to
> >
> > have libkexiv.
> >
> > > That means another package to maintain and another dependency. I'd
> > > expexted an internal kipi-plugins lib instead...
> > > Just a thought of course.
> >
> > As digikam and kipi-plugins will use it (and maybe later other kipi apps
> > or other image apps) it makes sense to do as standalone deb, like
> > libkipi is not in kipi-plugins.
> >
> > In general IMHO we need more libs than more apps :)
>
> What i find weird in the sources is this comment:
> ---------------
>  * NOTE: This class is a simplified version of Digikam::DMetadata
>  *       class from digiKam core. Please contact digiKam team
>  *       before to change/fix/improve this implementation.
> ---------------
>
> Sounds like we are duplicating code and making it a maintainance nightmare.
>
> Nobody is waiting to maintain this package, so my question is simple: who
> is going to generate packages for this library??
>
> Toma

And look like ShowImg use a copy of the digiKam core Exiv2 interface 
(DMetadata class) :

http://websvn.kde.org/trunk/extragear/graphics/showimg/showimg/metadata/dmetadata.cpp?rev=595799&view=auto

Witch is the same than :

http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp?rev=627043&view=auto

and where the kipi-plugins Exiv2Iface class is a simplified one :

http://websvn.kde.org/trunk/extragear/libs/kipi-plugins/common/exiv2iface/exiv2iface.cpp?rev=627061&view=auto

...It time to _UNIFIED_ all this world with a shared library...

Gilles



More information about the Digikam-devel mailing list